fix: remove auto instrument removal for stfc - #1212
Merged
Merged
Conversation
TCMeldrum
marked this pull request as ready for review
October 6, 2025 13:29
TCMeldrum
requested review from
a team,
RasmiaKulan and
mutambaraf
and removed request for
a team and
RasmiaKulan
October 6, 2025 13:29
bolmsten
approved these changes
Oct 8, 2025
Bhaswati1148
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1453
Description
This PR removes the automatic removal of instruments for STFC users.
Motivation and Context
The automatic removal of instruments for STFC is no longer needed, anyone who leaves will have there access to the instrument scientist role removed anyway. We are also looking into felxible roles and the auto assigments should be made obsolete as well.
Changes
getInstrumentsToRemoveandautoAssignRemoveInstrumentsfunctions fromStfcUserAuthorization.autoAssignRemoveInstrumentstoautoAssignInstrumentsand updated its usage across the codebase.How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?